From: Jonathan Corbet <corbet@lwn.net>
To: Arjan van de Ven <arjan@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH, RFC] fasync() BKL pushdown
Date: Fri, 20 Jun 2008 15:05:35 -0600 [thread overview]
Message-ID: <20080620150535.5efc2ec0@bike.lwn.net> (raw)
In-Reply-To: <20080620135840.562dd4a5@infradead.org>
On Fri, 20 Jun 2008 13:58:40 -0700
Arjan van de Ven <arjan@infradead.org> wrote:
> only question is if this one is really needed:
> + lock_kernel();
> tty = (struct tty_struct *)filp->private_data;
> if (tty_paranoia_check(tty, filp->f_path.dentry->d_inode,
> "tty_fasync"))
> - return 0;
> + goto out;
>
> retval = fasync_helper(fd, filp, on, &tty->fasync);
> if (retval <= 0)
>
> (given that it just calls the helper.. mostly and that Alan has been
> busy removing the BKL from the tty layer)
There's enough other stuff going on there, including manipulations of
the tty_struct, waitqueue_active() checks, etc., that I figured I should
really leave the BKL in there and let Alan figure it out. I've learned
that it's best to tread with great care in that part of the kernel...
jon
Jonathan Corbet / LWN.net / corbet@lwn.net
prev parent reply other threads:[~2008-06-20 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 17:29 Jonathan Corbet
2008-06-20 17:55 ` Andi Kleen
2008-06-20 19:09 ` Jonathan Corbet
2008-06-20 19:12 ` Andi Kleen
2008-06-25 22:30 ` [PATCH, RFC] fasync() BKL pushdown (take 2) Jonathan Corbet
2008-06-27 8:48 ` Andi Kleen
2008-06-20 20:58 ` [PATCH, RFC] fasync() BKL pushdown Arjan van de Ven
2008-06-20 21:05 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620150535.5efc2ec0@bike.lwn.net \
--to=corbet@lwn.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®