From: David Brownell <david-b@pacbell.net>
To: Adrian Bunk <bunk@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, rtc-linux@googlegroups.com
Subject: Re: [patch 2.6.26-rc7] <linux/bcd.h> space reduction
Date: Mon, 23 Jun 2008 00:15:49 -0700 [thread overview]
Message-ID: <200806230015.49973.david-b@pacbell.net> (raw)
In-Reply-To: <20080623065034.GG20122@cs181140183.pp.htv.fi>
On Sunday 22 June 2008, Adrian Bunk wrote:
> On Sun, Jun 22, 2008 at 07:54:36PM -0700, David Brownell wrote:
> > This updates <linux/bcd.h> to define the key routines as static
> > constant functions, which the macros will then call.
> >
> > ... Typical per-driver savings top 200 bytes. ...
>
> The patch breaks the compilation:
Needs to #include <linux/types.h> then; "u8" isn't always known.
Or maybe just spell it out "unsigned char".
> ...
>
> Additionally, I'd suggest to make them out-of-line functions
> instead of shipping multiple copies in different object files.
That was one of the options. I thought I'd start with something
simpler, and see what folk thought.
Where would that be ... lib/bcd.c, always linked? And if it goes
that way I'd prefer bcd2bin() and bin2bcd(), not these names. A
small impetus to have LESS SOURCE CODE SHOUTING AT ME.
- Dave
next prev parent reply other threads:[~2008-06-23 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 2:54 David Brownell
2008-06-23 6:50 ` Adrian Bunk
2008-06-23 7:15 ` David Brownell [this message]
2008-06-24 21:54 ` Adrian Bunk
2008-06-30 0:41 ` David Brownell
2008-06-30 18:20 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806230015.49973.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®