From: Pavel Machek <pavel@suse.cz>
To: "Chen, Huacai" <huacai.chen@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
lenb@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [PATCH]ACPI: Fix CMOS time error after waking up by /proc/acpi/alarm
Date: Mon, 23 Jun 2008 11:10:51 +0200 [thread overview]
Message-ID: <20080623091051.GA1917@elf.ucw.cz> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC0148CB4C@pdsmsx415.ccr.corp.intel.com>
On Thu 2008-06-19 21:52:02, Chen, Huacai wrote:
> From: Huacai Chen <huacai.chen@intel.com>
>
> When writing /proc/acpi/alarm to wakeup up in adjust mode, this patch
> read the "century" filed and add it to the "year" field before writing.
> This avoids the CMOS time error (2000 years decrement) after waking up.
>
> Signed-off-by: Huacai Chen <huacai.chen@intel.com>
Probably word-wrapped,
> ---
> diff --git a/drivers/acpi/sleep/proc.c b/drivers/acpi/sleep/proc.c
> index 224c57c..2a85783 100644
> --- a/drivers/acpi/sleep/proc.c
> +++ b/drivers/acpi/sleep/proc.c
> @@ -315,8 +315,11 @@ acpi_system_write_alarm(struct file *file,
> cmos_bcd_write(day, acpi_gbl_FADT.day_alarm,
> rtc_control);
> if (acpi_gbl_FADT.month_alarm)
> cmos_bcd_write(mo, acpi_gbl_FADT.month_alarm,
> rtc_control);
> - if (acpi_gbl_FADT.century)
> + if (acpi_gbl_FADT.century){
and you definitely want ") {" here.
It probably should go to Len and RTC maintainers?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-06-23 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 13:52 Chen, Huacai
2008-06-23 9:10 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623091051.GA1917@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=huacai.chen@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®