From: Marin Mitov <mitov@issp.bas.bg>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [BUGs] must check return value of pci_map_single()/pci_map_page()
Date: Mon, 23 Jun 2008 14:06:22 +0300 [thread overview]
Message-ID: <200806231406.23027.mitov@issp.bas.bg> (raw)
Hi all,
According to Documentation/DMA-mapping.txt one should
check the return value of pci_map_single()/pci_map_page()
using pci_dma_mapping_error(), but many drivers do not.
(I have checked in drivers/net/* for example).
Should we add __must_check in the definitions/declarations
of these functions/macros "to force" the check?
Best regards
Marin Mitov
reply other threads:[~2008-06-23 11:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806231406.23027.mitov@issp.bas.bg \
--to=mitov@issp.bas.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®