From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Hans de Goede <j.w.r.degoede@hhs.nl>,
Zhang Rui <rui.zhang@intel.com>,
Jean Delvare <khali@linux-fr.org>,
linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace
Date: Mon, 23 Jun 2008 13:06:57 -0400 [thread overview]
Message-ID: <20080623170657.GK7306@mars.solarsys.private> (raw)
In-Reply-To: <485FBBE6.9000104@keyaccess.nl>
Linus, Rene, et al:
* Rene Herman <rene.herman@keyaccess.nl> [2008-06-23 17:06:14 +0200]:
> drivers/thermal/thermal_sys.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 6098787..c21e03c 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -357,7 +357,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
>
> INIT_LIST_HEAD(&hwmon->tz_list);
> strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH);
> - hwmon->device = hwmon_device_register(NULL);
> + hwmon->device = hwmon_device_register(&tz->device);
> if (IS_ERR(hwmon->device)) {
> result = PTR_ERR(hwmon->device);
> goto free_mem;
NACK.
1) The bug is in libsensors (2.10), not the kernel.
- but more importantly -
2) This patch is broken.
Regards,
--
Mark M. Hoffman
mhoffman@lightlink.com
next prev parent reply other threads:[~2008-06-23 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 15:06 Rene Herman
2008-06-23 17:06 ` Mark M. Hoffman [this message]
[not found] <fa.4PGqX9CuLbgiTimfCcon+PlAMxk@ifi.uio.no>
[not found] ` <fa.PWu620xEt5OlYdOezvRtQriuNjM@ifi.uio.no>
2008-06-24 2:17 ` Robert Hancock
2008-06-24 3:07 ` Linus Torvalds
2008-06-24 3:47 ` Zhang Rui
2008-06-24 12:14 ` Mark M. Hoffman
2008-06-24 17:38 ` Rene Herman
2008-06-25 23:12 ` Len Brown
2008-06-26 0:17 ` Matthew Garrett
2008-06-25 23:16 ` Len Brown
2008-06-25 23:38 ` Rene Herman
2008-06-26 0:57 ` Zhang Rui
2008-06-24 6:59 ` Jean Delvare
2008-06-24 9:28 ` Rene Herman
2008-06-24 11:45 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623170657.GK7306@mars.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=j.w.r.degoede@hhs.nl \
--cc=khali@linux-fr.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rene.herman@keyaccess.nl \
--cc=rui.zhang@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®