From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SGI UV: uv_ptc_proc_write security hole
Date: Mon, 23 Jun 2008 23:13:35 +0200 [thread overview]
Message-ID: <20080623211335.GA12877@elte.hu> (raw)
In-Reply-To: <E1KAm9h-0002Fe-8a@eag09.americas.sgi.com>
* Cliff Wickman <cpw@sgi.com> wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> Someone could write 0 bytes to /proc/sgi_uv/ptc_statistics,
> causing
> optstr[count - 1] = '\0';
> to write to who-knows-where.
>
> (Andi Kleen noticed this need from a patch I sent for
> similar code in the ia64 world (sn2_ptc_proc_write()).)
>
> (count less than zero is not possible here, as count is unsigned)
>
> Diffed against 2.6.26-rc6
applied to tip/x86/uv - thanks Cliff.
Ingo
prev parent reply other threads:[~2008-06-23 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 13:32 Cliff Wickman
2008-06-23 21:13 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623211335.GA12877@elte.hu \
--to=mingo@elte.hu \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®