From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Suresh B Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 0/7] x86: pat.c: reserve_memtype strip down
Date: Tue, 24 Jun 2008 13:08:21 +0200 [thread overview]
Message-ID: <20080624110820.GB8695@elte.hu> (raw)
In-Reply-To: <20080620195503.GB4105@alberich.amd.com>
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> This patch set will (first of all) cleanup reserve_memtype a little
> bit to make it easier to read and maintain.
>
> (... and hopefully it doesn't break anything.;-)
applied to tip/x86/pat - thanks Andreas.
> Instead of sending one large patch I broke it down into several pieces
> to make it easier to review.
thanks!
A nice splitup not only makes review easier but in the (i know, very
unlikely ;-) case of breakage it narrows down the problem change.
It also makes maintenance and integration easier.
Especially for architecture code it is very important to do as small
changes as possible.
Ingo
next prev parent reply other threads:[~2008-06-24 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 19:55 Andreas Herrmann
2008-06-20 19:58 ` [PATCH 1/7] x86: introduce macro to check whether an address range is in the ISA range Andreas Herrmann
2008-06-20 20:01 ` [PATCH 2/7] x86: pat.c choose more crisp variable names Andreas Herrmann
2008-06-20 20:03 ` [PATCH 3/7] x86: pat.c more trivial changes Andreas Herrmann
2008-06-20 20:04 ` [PATCH 4/7] x86: pat.c consolidate error/debug messages in reserve_memtype Andreas Herrmann
2008-06-20 20:05 ` [PATCH 5/7] x86: pat.c consolidate list_add handling " Andreas Herrmann
2008-06-20 20:07 ` [PATCH 6/7] x86: pat.c introduce function to check for conflicts with existing memtypes Andreas Herrmann
2008-06-21 6:20 ` Brice Goglin
2008-06-20 20:08 ` [PATCH 7/7] x86: pat.c final cleanup of loop body in reserve_memtype Andreas Herrmann
2008-06-24 11:08 ` Ingo Molnar [this message]
2008-06-24 21:59 ` [PATCH 0/7] x86: pat.c: reserve_memtype strip down Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624110820.GB8695@elte.hu \
--to=mingo@elte.hu \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®