From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Johannes Weiner <hannes@saeurebad.de>,
Philippe Elie <phil.el@wanadoo.fr>,
oprofile-list@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/oprofile: disable preemption in nmi_shutdown
Date: Tue, 24 Jun 2008 13:49:17 +0200 [thread overview]
Message-ID: <20080624114917.GE21890@elte.hu> (raw)
In-Reply-To: <20080622074018.GA3163@damson.getinternet.no>
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Sat, 21 Jun 2008 23:44:19 +0200
> Subject: [PATCH] x86/oprofile: disable preemption in nmi_shutdown
>
> BUG: using smp_processor_id() in preemptible [00000000] code: oprofiled/27301
> caller is nmi_shutdown+0x11/0x60
> Pid: 27301, comm: oprofiled Not tainted 2.6.26-rc7 #25
> [<c028a90d>] debug_smp_processor_id+0xbd/0xc0
> [<c045fba1>] nmi_shutdown+0x11/0x60
> [<c045dd4a>] oprofile_shutdown+0x2a/0x60
>
> Note that we don't need this for the other functions, since they are
> all called with on_each_cpu() (which disables preemption for us
> anyway).
applied to tip/x86/oprofile - thanks Vegard.
Ingo
prev parent reply other threads:[~2008-06-24 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 18:28 v2.6.26-rc7/oprofile: BUG: using smp_processor_id() in preemptible Vegard Nossum
2008-06-21 21:55 ` [PATCH] x86/oprofile: disable preemption in nmi_shutdown Vegard Nossum
2008-06-22 7:30 ` Johannes Weiner
2008-06-22 7:40 ` Vegard Nossum
2008-06-24 11:49 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624114917.GE21890@elte.hu \
--to=mingo@elte.hu \
--cc=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=phil.el@wanadoo.fr \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®