From: Gregory Haskins <ghaskins@novell.com>
To: mingo@elte.hu, rostedt@goodmis.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
linux-rt-users@vger.kernel.org, ghaskins@novell.com,
dbahi@novell.com, npiggin@suse.de
Subject: [PATCH 1/3] sched: limit "all_pinned" balance attempts to sd->span
Date: Tue, 24 Jun 2008 08:16:02 -0600 [thread overview]
Message-ID: <20080624141602.28487.81775.stgit@lsg.lsg.lab.novell.com> (raw)
In-Reply-To: <20080624141527.28487.77778.stgit@lsg.lsg.lab.novell.com>
Load-balancing will never terminate if all cpus are "all_pinned" with
the current algorithm. This would be pretty unlikely to occur, but we
should protect against it nonetheless.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
kernel/sched.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 31f91d9..54b27b4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3178,7 +3178,8 @@ static int load_balance(int this_cpu, struct rq *this_rq,
struct sched_group *group;
unsigned long imbalance;
struct rq *busiest;
- cpumask_t cpus = CPU_MASK_ALL;
+ cpumask_t cpus = sd->span;
+ int remain = cpus_weight(sd->span) - 1;
unsigned long flags;
/*
@@ -3237,11 +3238,10 @@ redo:
resched_cpu(this_cpu);
/* All tasks on this runqueue were pinned by CPU affinity */
- if (unlikely(all_pinned)) {
+ if (unlikely(all_pinned && remain)) {
cpu_clear(cpu_of(busiest), cpus);
- if (!cpus_empty(cpus))
- goto redo;
- goto out_balanced;
+ remain--;
+ goto redo;
}
}
@@ -3332,7 +3332,8 @@ load_balance_newidle(int this_cpu, struct rq *this_rq, struct sched_domain *sd)
int ld_moved = 0;
int sd_idle = 0;
int all_pinned = 0;
- cpumask_t cpus = CPU_MASK_ALL;
+ cpumask_t cpus = sd->span;
+ int remain = cpus_weight(sd->span) - 1;
/*
* When power savings policy is enabled for the parent domain, idle
@@ -3375,10 +3376,10 @@ redo:
&all_pinned);
spin_unlock(&busiest->lock);
- if (unlikely(all_pinned)) {
+ if (unlikely(all_pinned && remain)) {
cpu_clear(cpu_of(busiest), cpus);
- if (!cpus_empty(cpus))
- goto redo;
+ remain--;
+ goto redo;
}
}
next prev parent reply other threads:[~2008-06-24 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:15 [PATCH 0/3] RT: scheduler newidle enhancements v2 Gregory Haskins
2008-06-24 14:16 ` Gregory Haskins [this message]
2008-06-25 13:19 ` [PATCH 1/3] sched: limit "all_pinned" balance attempts to sd->span Gregory Haskins
2008-06-24 14:16 ` [PATCH 2/3] sched: enable interrupts and drop rq-lock during newidle balancing Gregory Haskins
2008-06-24 14:16 ` [PATCH 3/3] sched: terminate newidle balancing once at least one task has moved over Gregory Haskins
-- strict thread matches above, loose matches on Subject: below --
2008-06-24 14:14 [PATCH 0/3] RT: scheduler newidle enhancements v2 Gregory Haskins
2008-06-24 14:14 ` [PATCH 1/3] sched: limit "all_pinned" balance attempts to sd->span Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624141602.28487.81775.stgit@lsg.lsg.lab.novell.com \
--to=ghaskins@novell.com \
--cc=dbahi@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®