From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: David Vrabel <david.vrabel@csr.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: PCI: MSI interrupts masked using prohibited method
Date: Wed, 25 Jun 2008 14:20:51 -0700 [thread overview]
Message-ID: <200806251420.51751.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <4860D09D.4060801@csr.com>
On Tuesday, June 24, 2008 3:46 am David Vrabel wrote:
> PCI MSI interrupts are masked and unmasked using a method (by writing
> the MSI Enable capability bit) that is prohibited by the PCI specification.
Yeah, it's probably quite a bit slower too (I assume you're talking about
io_apic_64's msi_mask_irq). Seems like masking this at the ioapic level
would make more sense anyway...
> This behaviour can cause missed interrupts with some devices if the
> interrupt is asserted by the hardware while MSI is disabled.
>
> I believe the interrupt should be masked/unmasked on the interrupt
> controller (the APIC on x86, for example). I'm going to test this now
> and see if it works.
Great, thanks.
Jesse
next prev parent reply other threads:[~2008-06-25 21:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 10:46 David Vrabel
2008-06-25 21:20 ` Jesse Barnes [this message]
2008-06-27 12:17 ` David Vrabel
2008-06-27 17:07 ` Jesse Barnes
2008-07-16 19:43 ` Jesse Barnes
2008-07-16 19:58 ` Matthew Wilcox
2008-07-16 20:35 ` David Miller
2008-07-17 12:16 ` Krzysztof Halasa
2008-07-17 12:43 ` Matthew Wilcox
2008-07-17 13:14 ` David Vrabel
2008-07-17 15:39 ` Matthew Wilcox
2008-07-17 15:58 ` Thomas Gleixner
2008-07-17 16:11 ` Matthew Wilcox
2008-07-17 17:04 ` Thomas Gleixner
2008-07-17 16:56 ` Matthew Wilcox
[not found] ` <487F7DFA.10101@csr.com>
2008-07-17 19:48 ` Matthew Wilcox
2008-07-18 10:33 ` David Vrabel
2008-07-22 13:56 ` Michal Schmidt
2008-07-22 17:52 ` Jesse Barnes
2008-07-23 13:02 ` Michal Schmidt
2008-07-25 13:29 ` Michal Schmidt
2008-07-25 13:42 ` Matthew Wilcox
2008-07-25 13:53 ` Michal Schmidt
2008-07-25 15:51 ` Matthew Wilcox
2008-07-28 9:54 ` Michal Schmidt
2008-07-25 16:37 ` David Vrabel
2008-07-25 16:56 ` Matthew Wilcox
2008-07-25 19:12 ` Jesse Barnes
2008-07-28 9:59 ` Michal Schmidt
2008-07-28 22:04 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806251420.51751.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=david.vrabel@csr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome