From: David Brownell <david-b@pacbell.net>
To: Jonathan Corbet <corbet@lwn.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] rtc: remove BKL for ioctl()
Date: Wed, 25 Jun 2008 15:58:45 -0700 [thread overview]
Message-ID: <200806251558.45809.david-b@pacbell.net> (raw)
In-Reply-To: <20080625163928.4da1f4a0@bike.lwn.net>
On Wednesday 25 June 2008, Jonathan Corbet wrote:
> On Sun, 22 Jun 2008 19:55:42 -0700
> David Brownell <david-b@pacbell.net> wrote:
>
> > Remove implicit use of BKL in ioctl() from the RTC framework.
>
> Looks good, I'll happily put it into the bkl-removal tree.
It's in MM now too ... are all the bkl-removal patches going in
at once, or will they be merged through their subsystems?
> One question, though:
>
> > + err = mutex_lock_interruptible(&rtc->ops_lock);
> > + if (err)
> > + return -EBUSY;
> > +
>
> Shouldn't that be -EINTR?
I was just copying that usage from drivers/rtc/interface.c ...
all users there return -EBUSY.
If it's wrong in this patch it's probably wrong there too.
I suspect EINTR is the answer in all cases.
- Dave
prev parent reply other threads:[~2008-06-25 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 2:55 David Brownell
2008-06-25 8:57 ` [rtc-linux] " Alessandro Zummo
2008-06-25 22:39 ` Jonathan Corbet
2008-06-25 22:30 ` Alan Cox
2008-06-25 23:04 ` David Brownell
2008-06-25 23:41 ` Jonathan Corbet
2008-06-25 22:58 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806251558.45809.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome