mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>
Subject: [patch] softlockup: print a module list on being stuck
Date: Wed, 25 Jun 2008 18:36:51 +0200	[thread overview]
Message-ID: <20080625163651.GA26706@elte.hu> (raw)


Linus,

Arjan has been observing lots of softlockup reports on kerneloops.org 
and would like to have the patch below in v2.6.26 to narrow the real 
source of it down some more, and has asked for this patch to be applied 
sooner than planned.

The patch is queued up for the next merge window at the moment. It's 
well-tested and obvious. The module list is printed here the same way 
it's printed for oopses.

Discard it if you feel in any way nervous about it.

	Ingo

---------------->
commit 688c91755dc3d3c03d8c67c1df13c02be258768e
Author: Arjan van de Ven <arjan@linux.intel.com>
Date:       Mon Jun 16 15:51:08 2008 -0700
CommitDate: Wed Jun 18 15:26:54 2008 +0200

    softlockup: print a module list on being stuck
    
    Most places in the kernel that go BUG: print a module list
    (which is very useful for doing statistics and finding patterns),
    however the softlockup detector does not do this yet.
    
    This patch adds the one line change to fix this gap.
    
    Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/kernel/softlockup.c b/kernel/softlockup.c
index 6b682d8..f2bf5de 100644
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -143,6 +143,7 @@ void softlockup_tick(void)
 	printk(KERN_ERR "BUG: soft lockup - CPU#%d stuck for %lus! [%s:%d]\n",
 			this_cpu, now - touch_timestamp,
 			current->comm, task_pid_nr(current));
+	print_modules();
 	if (regs)
 		show_regs(regs);
 	else

             reply	other threads:[~2008-06-25 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 16:36 Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-16 22:51 [PATCH] " Arjan van de Ven
2008-06-18 13:27 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625163651.GA26706@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®