From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756032AbYFZKC1@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756032AbYFZKC1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Jun 2008 06:02:27 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752277AbYFZKCS
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 26 Jun 2008 06:02:18 -0400
Received: from mx3.mail.elte.hu ([157.181.1.138]:33908 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751771AbYFZKCR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Jun 2008 06:02:17 -0400
Date: Thu, 26 Jun 2008 12:02:00 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/16] x86: merge setup_32/64.c
Message-ID: <20080626100200.GA15291@elte.hu>
References: <200806251748.06743.yhlu.kernel@gmail.com> <20080626094743.GA19573@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080626094743.GA19573@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-ELTE-VirusStatus: clean
X-ELTE-SpamScore: -1.5
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3
	-1.5 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ingo Molnar <mingo@elte.hu> wrote:

>       x86: rename setup.c to setup_percpu.c

this brought a build failure:

 arch/x86/kernel/setup.c: In function ‘setup_arch':
 arch/x86/kernel/setup.c:561: error: implicit declaration of function ‘efi_reserve_early'

09865f3049050458a5c236e5b4630f137d9b179d is first bad commit
commit 09865f3049050458a5c236e5b4630f137d9b179d
Author: Yinghai Lu <yhlu.kernel@gmail.com>
Date:   Wed Jun 25 17:48:14 2008 -0700

    x86: rename setup.c to setup_percpu.c

we lost an asm/efi.h include. (which, a bit illogically, is not implicit 
via the existing linux/efi.h include.) Fixed below.

	Ingo

-------------->
commit 9faea5db92f5ff3b39e7b66656f847dcb9618caa
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu Jun 26 12:02:01 2008 +0200

    x86: build fix
    
    fix:
    
    arch/x86/kernel/setup.c: In function ‘setup_arch':
    arch/x86/kernel/setup.c:561: error: implicit declaration of function ‘efi_reserve_early'
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index a3f2263..29f04da 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -79,6 +79,7 @@
 #include <asm/mpspec.h>
 #include <asm/setup.h>
 #include <asm/arch_hooks.h>
+#include <asm/efi.h>
 #include <asm/sections.h>
 #include <asm/dmi.h>
 #include <asm/io_apic.h>