From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <lenb@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-acpi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [patch 3/6] PCI: print "bar", not "bar + 1" in pci_request_region()
Date: Fri, 27 Jun 2008 08:45:41 -0600 [thread overview]
Message-ID: <20080627144753.399881942@ldl.fc.hp.com> (raw)
In-Reply-To: <20080627144538.743154341@ldl.fc.hp.com>
[-- Attachment #1: pci-request-region-bar-fix --]
[-- Type: text/plain, Size: 747 bytes --]
Change the BAR number printed by pci_request_region() from "bar + 1" to "bar".
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work11/drivers/pci/pci.c
===================================================================
--- work11.orig/drivers/pci/pci.c 2008-06-27 08:27:29.000000000 -0600
+++ work11/drivers/pci/pci.c 2008-06-27 08:27:47.000000000 -0600
@@ -1116,7 +1116,7 @@ int pci_request_region(struct pci_dev *p
err_out:
dev_warn(&pdev->dev, "BAR %d: can't reserve %s region [%#llx-%#llx]\n",
- bar + 1, /* PCI BAR # */
+ bar, /* PCI BAR # */
pci_resource_flags(pdev, bar) & IORESOURCE_IO ? "I/O" : "mem",
(unsigned long long)pci_resource_start(pdev, bar),
(unsigned long long)pci_resource_end(pdev, bar));
--
next prev parent reply other threads:[~2008-06-27 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 14:45 [patch 0/6] dev_printk() conversions, v2 Bjorn Helgaas
2008-06-27 14:45 ` [patch 1/6] ACPI: use dev_printk when possible Bjorn Helgaas
2008-06-28 4:45 ` Len Brown
2008-06-27 14:45 ` [patch 2/6] PCI: " Bjorn Helgaas
2008-06-27 14:45 ` Bjorn Helgaas [this message]
2008-06-27 14:45 ` [patch 4/6] PCIE: aer: " Bjorn Helgaas
2008-06-27 14:45 ` [patch 5/6] PCIE: port driver: " Bjorn Helgaas
2008-06-27 14:45 ` [patch 6/6] x86 PCI: " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627144753.399881942@ldl.fc.hp.com \
--to=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®