From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] coredump: turn core_state->nr_threads into atomic_t
Date: Sat, 28 Jun 2008 17:17:18 +0400 [thread overview]
Message-ID: <20080628131718.GA4418@tv-sign.ru> (raw)
Turn core_state->nr_threads into atomic_t and kill now unneeded
down_write(&mm->mmap_sem) in exit_mm().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
include/linux/mm_types.h | 2 +-
kernel/exit.c | 5 ++---
fs/exec.c | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
--- 26-rc2/include/linux/mm_types.h~4_NR_ATOMIC 2008-06-15 15:26:29.000000000 +0400
+++ 26-rc2/include/linux/mm_types.h 2008-06-16 18:00:08.000000000 +0400
@@ -160,7 +160,7 @@ struct vm_area_struct {
};
struct core_state {
- int nr_threads;
+ atomic_t nr_threads;
struct completion startup;
};
--- 26-rc2/kernel/exit.c~4_NR_ATOMIC 2008-06-15 15:28:21.000000000 +0400
+++ 26-rc2/kernel/exit.c 2008-06-16 19:58:59.000000000 +0400
@@ -667,10 +667,9 @@ static void exit_mm(struct task_struct *
down_read(&mm->mmap_sem);
if (mm->core_state) {
up_read(&mm->mmap_sem);
- down_write(&mm->mmap_sem);
- if (!--mm->core_state->nr_threads)
+
+ if (atomic_dec_and_test(&mm->core_state->nr_threads))
complete(&mm->core_state->startup);
- up_write(&mm->mmap_sem);
wait_for_completion(&mm->core_done);
down_read(&mm->mmap_sem);
--- 26-rc2/fs/exec.c~4_NR_ATOMIC 2008-06-16 17:23:59.000000000 +0400
+++ 26-rc2/fs/exec.c 2008-06-16 19:59:26.000000000 +0400
@@ -1585,7 +1585,7 @@ static inline int zap_threads(struct tas
}
rcu_read_unlock();
done:
- core_state->nr_threads = nr;
+ atomic_set(&core_state->nr_threads, nr);
mm->core_state = core_state;
return nr;
}
next reply other threads:[~2008-06-28 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 13:17 Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-06 15:22 Oleg Nesterov
2008-06-16 16:31 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080628131718.GA4418@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®