From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: linux-kernel@vger.kernel.org, kernel@avr32linux.org,
Andrew Victor <linux@maxim.org.za>,
Chip Coldwell <coldwell@redhat.com>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Subject: Re: [PATCH 1/2] serial: Add flush_buffer() operation to uart_ops
Date: Mon, 30 Jun 2008 11:12:48 +0100 [thread overview]
Message-ID: <20080630111248.567795df@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1214821461-11772-1-git-send-email-haavard.skinnemoen@atmel.com>
On Mon, 30 Jun 2008 12:24:20 +0200
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> Serial drivers using DMA (like the atmel_serial driver) tend to get very
> confused when the xmit buffer is flushed and nobody told them. They
> also tend to spew a lot of garbage since the DMA engine keeps running
> after the buffer is flushed and possibly refilled with unrelated data.
>
> This patch adds a new flush_buffer operation to the uart_ops struct,
> along with a call to it from uart_flush_buffer() right after the xmit
> buffer has been cleared. The driver can implement this in order to
> syncronize its internal DMA state with the xmit buffer when the buffer
> is flushed.
>
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-06-30 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 10:24 Haavard Skinnemoen
2008-06-30 10:12 ` Alan Cox [this message]
2008-06-30 10:24 ` [PATCH 2/2] atmel_serial: Implement flush_buffer() hook Haavard Skinnemoen
2008-06-30 10:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630111248.567795df@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=coldwell@redhat.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®