From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763321AbYF3Pce (ORCPT ); Mon, 30 Jun 2008 11:32:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757965AbYF3P17 (ORCPT ); Mon, 30 Jun 2008 11:27:59 -0400 Received: from aeryn.fluff.org.uk ([87.194.8.8]:60314 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750842AbYF3P1u (ORCPT ); Mon, 30 Jun 2008 11:27:50 -0400 Message-Id: <20080630152748.737462327@fluff.org.uk> References: <20080630152547.755285683@fluff.org.uk> User-Agent: quilt/0.46-1 Date: Mon, 30 Jun 2008 16:25:56 +0100 From: Ben Dooks To: linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx Cc: tk@maintech.de, laforge@openmoko.org, Ben Dooks Subject: [patch v4 09/17] MMC: S3C24XX: Ensure host->mrq->data is valid Content-Disposition: inline; filename=simtec/s3c24xx-sdmmc-piotasklet-crashfix.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a crash if host->mrq->data is NULL on ending a transfer. Signed-off-by: Ben Dooks Index: linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c =================================================================== --- linux-2.6.26-rc8-next20080627.orig/drivers/mmc/host/s3cmci.c 2008-06-30 12:36:42.000000000 +0100 +++ linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c 2008-06-30 12:36:49.000000000 +0100 @@ -353,7 +353,8 @@ static void pio_tasklet(unsigned long da (host->pio_active == XFER_READ) ? "read" : "write", host->pio_count, host->pio_words); - host->mrq->data->error = -EINVAL; + if (host->mrq->data) + host->mrq->data->error = -EINVAL; } finalize_request(host); -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'