mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
	user-mode-linux-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix extern inline errors with gcc 4.3.0
Date: Mon, 30 Jun 2008 19:43:24 +0300	[thread overview]
Message-ID: <20080630164324.GA1536@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080630162201.GC6643@c2.user-mode-linux.org>

On Mon, Jun 30, 2008 at 12:22:01PM -0400, Jeff Dike wrote:
> On Sun, Jun 29, 2008 at 10:32:43AM +0300, Benny Halevy wrote:
> > Note that the crash happened with gcc 4.1.2 and it will get the
> > -fno-unit-at-a-time flag with the proposed patch.
> > 
> > That said, this option or the lack of it ought not to cause any
> > runtime crashes.  If it does, I'd feel much more comfortable to know
> > exactly what the root cause is before deciding to use the flag to
> > workaround^hide it.
> 
> I agree.
> 
> The constraints on [no-]unit-at-a-time that I see are:
>...
> 	x86_64 uses unit-at-a-time always
>...

The only gcc versions that ever supported unit-at-a-time without 
enabling it by default was some patched gcc 3.3 that included a
backport of unit-at-a-time to gcc 3.3.

Just as a note that I doubt this matters in practice today.

> 				Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2008-06-30 16:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26 13:50 Benny Halevy
2008-06-27 16:26 ` Jeff Dike
2008-06-28 13:10   ` Halevy, Benny
2008-06-29  7:32     ` Benny Halevy
2008-06-30 16:22       ` Jeff Dike
2008-06-30 16:37         ` Benny Halevy
2008-07-07 16:58           ` Jeff Dike
2008-06-30 16:43         ` Adrian Bunk [this message]
2008-08-08  1:02         ` [uml-devel] " Rob Landley
2008-08-08  1:42         ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080630164324.GA1536@cs181140183.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=bhalevy@panasas.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®