From: Michael Buesch <mb@bu3sch.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-pci@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
jejb <James.Bottomley@hansenpartnership.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
Date: Mon, 30 Jun 2008 23:10:12 +0200 [thread overview]
Message-ID: <200806302310.12478.mb@bu3sch.de> (raw)
In-Reply-To: <200806301400.02455.jbarnes@virtuousgeek.org>
On Monday 30 June 2008 23:00:02 Jesse Barnes wrote:
> On Monday, June 30, 2008 1:40 pm Michael Buesch wrote:
> > On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> > > On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > >
> > > > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > > > so add one like other similar stubs. Otherwise there can be build
> > > > errors, as here:
> > > >
> > > > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit
> > > > declaration of function 'pci_set_consistent_dma_mask'
> > > >
> > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Applied to linux-next, thanks Randy.
> >
> > I guess this is probably also needed for 2.6.26.
>
> Hm, current upstream seems to have pci_set_consistent_dma_mask under
> CONFIG_SSB_PCIHOST, which in turn depends on PCI = y (or PCI = SSB, what does
> that mean?).
>
> But yeah, it wouldn't hurt to push this for 2.6.26 too.
Yeah, I wasn't talking about ssb, but rather other drivers.
Maybe there's no such user of that function, however.
--
Greetings Michael.
next prev parent reply other threads:[~2008-06-30 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 18:35 Randy Dunlap
2008-06-30 18:42 ` Jesse Barnes
2008-06-30 20:40 ` Michael Buesch
2008-06-30 21:00 ` Jesse Barnes
2008-06-30 21:10 ` Michael Buesch [this message]
2008-06-30 21:12 ` Michael Buesch
2008-07-02 4:31 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806302310.12478.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome