From: Adrian Bunk <bunk@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: -Wmissing-prototypes (was: make foo() static)
Date: Tue, 1 Jul 2008 10:17:35 +0300 [thread overview]
Message-ID: <20080701071735.GA17047@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <4869D1F3.3030804@redhat.com>
On Tue, Jul 01, 2008 at 08:42:59AM +0200, Gerd Hoffmann wrote:
> Adrian Bunk wrote:
>
> > This patch makes the needlessly global kvm_smp_prepare_boot_cpu() static.
>
> Hmm, maybe we should build the kernel with -Wmissing-prototypes?
> That should make gcc print a warning for that ...
I started 3 or 4 years ago cleaning up the kernel for
-Wmissing-prototypes and I'm still working on it.
Many parts of the kernel now compile cleanly or nearly cleanly, but
looking at e.g. arch/ I know what kind of answers I would get if
suggesting adding -Wmissing-prototypes today...
> cheers,
> Gerd
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-07-01 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 22:19 [2.6 patch] make kvm_smp_prepare_boot_cpu() static Adrian Bunk
2008-07-01 6:42 ` -Wmissing-prototypes (was: make foo() static) Gerd Hoffmann
2008-07-01 7:17 ` Adrian Bunk [this message]
2008-07-05 11:13 ` [2.6 patch] make kvm_smp_prepare_boot_cpu() static Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701071735.GA17047@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®