From: Ingo Molnar <mingo@elte.hu>
To: Mike Travis <travis@sgi.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Lameter <cl@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/5] percpu: Optimize percpu accesses
Date: Tue, 1 Jul 2008 16:54:17 +0200 [thread overview]
Message-ID: <20080701145417.GB18522@elte.hu> (raw)
In-Reply-To: <20080701121634.865966000@polaris-admin.engr.sgi.com>
* Mike Travis <travis@sgi.com> wrote:
> This patchset provides the following:
>
> * Cleanup: Fix early references to cpumask_of_cpu(0)
> * Generic: Percpu infrastructure to rebase the per cpu area to zero
> * x86_64: Fold pda into per cpu area
> * x86_64: Rebase per cpu variables to zero
thanks Mike - i've started testing it in -tip. One small merge fallout
fix is below. (it's for the new generic-ipi topic that was not in
tip/master yet when you merged percpu-zerobased to it)
Ingo
---------------->
commit d1d4ed23aab090298b9d4da0fe445b96afcdd309
Author: Ingo Molnar <mingo@elte.hu>
Date: Tue Jul 1 16:44:45 2008 +0200
x86: percpu-zerobased fallout fixlet
add_pda(x,1) => x86_inc_percpu(pda.x)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 361b7a4..1ddf629 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -206,7 +206,7 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
#ifdef CONFIG_X86_32
__get_cpu_var(irq_stat).irq_call_count++;
#else
- add_pda(irq_call_count, 1);
+ x86_inc_percpu(pda.irq_call_count);
#endif
irq_exit();
}
next prev parent reply other threads:[~2008-07-01 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 12:16 Mike Travis
2008-07-01 12:16 ` [RFC 1/5] x86_64: Fix early references to cpumask_of_cpu Mike Travis
2008-07-01 12:16 ` [RFC 2/5] x86_64: Fold pda into per cpu area Mike Travis
2008-07-01 12:16 ` [RFC 3/5] x86_64: Reference zero-based percpu variables offset from gs Mike Travis
2008-07-01 12:16 ` [RFC 4/5] x86_64: Replace cpu_pda ops with percpu ops Mike Travis
2008-07-01 12:16 ` [RFC 5/5] x86_64: Replace xxx_pda() operations with x86_xxx_percpu() Mike Travis
2008-07-01 14:54 ` Ingo Molnar [this message]
2008-07-01 15:03 ` [RFC 0/5] percpu: Optimize percpu accesses Ingo Molnar
2008-07-01 15:07 ` Mike Travis
2008-07-02 14:04 ` Mike Travis
2008-07-18 6:52 ` Ingo Molnar
2008-07-01 18:47 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701145417.GB18522@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®