mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	linux390@de.ibm.com, Kay Sievers <kay.sievers@vrfy.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/04] s390: bus_id -> dev_name conversions
Date: Wed, 2 Jul 2008 18:28:32 +0200	[thread overview]
Message-ID: <20080702182832.1a087e8d@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20080702154630.GA31083@kroah.com>

On Wed, 2 Jul 2008 08:46:30 -0700,
Greg KH <greg@kroah.com> wrote:

> @@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann
>  	}
>  	mutex_init(&sch->reg_mutex);
>  	/* Set a name for the subchannel */
> -	snprintf (sch->dev.bus_id, BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
> +	snprintf (dev_name(&sch->dev), BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
>  		  schid.sch_no);
> 
>  	/*

This hunk does not make much sense. Better just leave it alone until
the dev_set_name()/init_name conversion later.

  reply	other threads:[~2008-07-02 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02 15:46 Greg KH
2008-07-02 16:28 ` Cornelia Huck [this message]
2008-07-02 18:49   ` Greg KH
2008-07-03 15:18     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080702182832.1a087e8d@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=greg@kroah.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®