From: David Miller <davem@davemloft.net>
To: gregkh@suse.de
Cc: davem@daveloft.net, kay.sievers@vrfy.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc64: fix up bus_id changes in sparc core code
Date: Thu, 03 Jul 2008 03:35:56 -0700 (PDT) [thread overview]
Message-ID: <20080703.033556.167121752.davem@davemloft.net> (raw)
In-Reply-To: <20080702153651.GB30318@kroah.com>
From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Wed, 2 Jul 2008 08:36:51 -0700
> --- a/arch/sparc64/kernel/pci.c
> +++ b/arch/sparc64/kernel/pci.c
> @@ -408,7 +408,7 @@ struct pci_dev *of_create_pci_dev(struct
> dev->class = class >> 8;
> dev->revision = class & 0xff;
>
> - sprintf(dev->dev.bus_id, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> + dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
>
> if (ofpci_verbose)
Those lines read:
sprintf(pci_name(dev), "%04x:%02x:%02x.%d", pci_domain_nr(bus),
dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
in Linus's current tree.
What are you patching against? That first argument is not
dev->dev.bus_id in any tree I have sitting here, it's always
pci_name() :-)
next prev parent reply other threads:[~2008-07-03 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 15:36 Greg Kroah-Hartman
2008-07-03 10:35 ` David Miller [this message]
2008-07-03 16:49 ` Greg KH
2008-07-03 20:44 ` David Miller
2008-07-07 23:03 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703.033556.167121752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davem@daveloft.net \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®