From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757775AbYGDQuS (ORCPT ); Fri, 4 Jul 2008 12:50:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754705AbYGDQt6 (ORCPT ); Fri, 4 Jul 2008 12:49:58 -0400 Received: from xi.wantstofly.org ([83.160.184.112]:37453 "EHLO xi.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754444AbYGDQt5 (ORCPT ); Fri, 4 Jul 2008 12:49:57 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=1148133259; d=wantstofly.org; h=date:from:to:cc:subject:message-id:mime-version:content-type: content-disposition:in-reply-to:user-agent; b=L87xw8CmBu1doWNB5p+/RSGxj9OqIiSftA+mcjG2xOMlKH97U8OVROjULfpWH djwlq4g2MqjOJbQfz+Dey1n/A== Date: Fri, 4 Jul 2008 18:49:55 +0200 From: Lennert Buytenhek To: Takashi Iwai Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c Message-ID: <20080704164954.GA12106@xi.wantstofly.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 04, 2008 at 06:32:03PM +0200, Takashi Iwai wrote: > drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_netpoll': > drivers/net/mv643xx_eth.c:2115: error: 'INT_CAUSE_EXT' undeclared (first use in this function) > drivers/net/mv643xx_eth.c:2115: error: (Each undeclared identifier is reported only once > drivers/net/mv643xx_eth.c:2115: error: for each function it appears in. > > Signed-off-by: Takashi Iwai > > --- > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c > index 83a877f..cb2c065 100644 > --- a/drivers/net/mv643xx_eth.c > +++ b/drivers/net/mv643xx_eth.c > @@ -2112,7 +2112,8 @@ static void mv643xx_eth_netpoll(struct net_device *dev) > > mv643xx_eth_irq(dev->irq, dev); > > - wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_CAUSE_EXT); > + wrl(mp, INT_MASK(mp->port_num), > + INT_TX_END | INT_RX | INT_CAUSE_EXT(mp->port_num)); You are ORing the _address_ of the interrupt status register into the interupt mask register. How do you expect that to work? This is the proper fix, which I will re-submit shortly: http://marc.info/?l=linux-kernel&m=121498695309851&w=2