Re: usb-storage: quirk around v1.11 firmware on Nikon D4

[Matthew Dharm <mdharm-kernel@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

NAK.

Two entries should not have overlapping version ranges, unless
configuration options are involved.

Why not just extend the range of the existing entry?

Matt

On Fri, Jul 04, 2008 at 03:33:23PM -0400, Dave Jones wrote:
> usb-storage: quirk around v1.11 firmware on Nikon D40
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=454028
> Just as in earlier firmware versions, we need to perform this
> quirk for the latest version too.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 45fe366..cf03af1 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -364,6 +364,13 @@ UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_FIX_CAPACITY),
>  
> +/* Reported by https://bugzilla.redhat.com/show_bug.cgi?id=454028 */
> +UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0111,
> +		"NIKON",
> +		"NIKON DSC D40",
> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
> +		US_FL_FIX_CAPACITY),
> +
>  /* Reported by Ortwin Glueck <odi@odi.ch> */
>  UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0110,
>  		"NIKON",
> 
> 
> -- 
> http://www.codemonkey.org.uk
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

P:  How about "Web Designer"?
DP: I'd like a name that people won't laugh at.
					-- Pitr and Dust Puppy
User Friendly, 12/6/1997

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]