From: Andi Kleen <andi@firstfloor.org>
To: masbock@linux.vnet.ibm.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [2/9] MCE: Implement the PPro bank 0 quirk in the 64bit machine check code
Date: Fri, 4 Jul 2008 23:20:26 +0200 (CEST) [thread overview]
Message-ID: <20080704212026.B31F31B431F@basil.firstfloor.org> (raw)
In-Reply-To: <200807041120.678642023@firstfloor.org>
Quoting the comment:
* SDM documents that on family 6 bank 0 should not be written
* because it aliases to another special BIOS controlled
* register.
* But it's not aliased anymore on model 0x1a+
* Don't ignore bank 0 completely because there could be a valid
* event later, merely don't write CTL0.
This is mostly a port on the 32bit code, except that 32bit
always didn't write it and didn't have the 0x1a heuristic. I checked
with the CPU designers that the quirk is not required starting with
this model.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/cpu/mcheck/mce_64.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -433,6 +433,7 @@ static __init int periodic_mcheck_init(v
}
__initcall(periodic_mcheck_init);
+static int dont_init_bank0;
/*
* Initialize Machine Checks for a CPU.
@@ -462,7 +463,8 @@ static void mce_init(void *dummy)
wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff);
for (i = 0; i < banks; i++) {
- wrmsrl(MSR_IA32_MC0_CTL+4*i, bank[i]);
+ if (!(i == 0 && dont_init_bank0))
+ wrmsrl(MSR_IA32_MC0_CTL+4*i, bank[i]);
wrmsrl(MSR_IA32_MC0_STATUS+4*i, 0);
}
}
@@ -481,6 +483,18 @@ static void __cpuinit mce_cpu_quirks(str
by default and leave crap in there. Don't log. */
mce_bootlog = 0;
}
+ if (c->x86_vendor == X86_VENDOR_INTEL) {
+ /*
+ * SDM documents that on family 6 bank 0 should not be written
+ * because it aliases to another special BIOS controlled
+ * register.
+ * But it's not aliased anymore on model 0x1a+
+ * Don't ignore bank 0 completely because there could be a valid
+ * event later, merely don't write CTL0.
+ */
+ if (c->x86 == 6 && c->x86_model < 0x1A)
+ dont_init_bank0 = 1;
+ }
}
next prev parent reply other threads:[~2008-07-04 21:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 21:20 [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too Andi Kleen
2008-07-04 21:20 ` [PATCH] [1/9] MCE: Make 64bit mce code 32bit clean Andi Kleen
2008-07-04 21:20 ` Andi Kleen [this message]
2008-07-04 21:20 ` [PATCH] [3/9] MCE: Port K7 bank 0 quirk to 64bit mce code Andi Kleen
2008-07-04 21:20 ` [PATCH] [4/9] MCE: Call 64bit machine check through a call vector Andi Kleen
2008-07-04 21:20 ` [PATCH] [5/9] MCE: Rename mce_dont_init on 64bit to mce_disabled Andi Kleen
2008-07-04 21:20 ` [PATCH] [6/9] MCE: Provide exit_idle dummy functions for 32bit Andi Kleen
2008-07-04 21:20 ` [PATCH] [7/9] MCE: Remove machine check handler idle notify on 64bit Andi Kleen
2008-07-04 21:20 ` [PATCH] [8/9] MCE: Remove oops_begin() use in 64bit machine check Andi Kleen
2008-07-04 21:20 ` [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit Andi Kleen
2008-07-05 9:50 ` Bert Wesarg
2008-07-05 9:54 ` Andi Kleen
2008-07-05 10:17 ` Bert Wesarg
2008-07-05 10:55 ` Andi Kleen
2008-07-10 18:23 ` Pavel Machek
2008-07-07 21:26 ` [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too H. Peter Anvin
2008-07-07 21:37 ` H. Peter Anvin
2008-07-08 0:00 ` Max Asbock
2008-07-08 0:25 ` Andi Kleen
2008-07-07 22:09 ` Andi Kleen
2008-07-07 6:28 Andi Kleen
2008-07-07 6:28 ` [PATCH] [2/9] MCE: Implement the PPro bank 0 quirk in the 64bit machine check code Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704212026.B31F31B431F@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome