Re: [regression] Re: 2.6.26-rc6: pcmcia stopped working

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > > Hmm, hitting sysrq-w produces no blocked task until I eject pcmcia
> > > > card. Backtrace there is:
> > > > 
> > > > Greg, I believe some traces lead to sysfs, can you help here?
> > > 
> > > ide_unregister() does not complete :-(.
> > > 
> > >         device_unregister(&hwif->gendev);
> > > +       printk("ide_unregister: waiting for rel_comp\n");
> > >         wait_for_completion(&hwif->gendev_rel_comp);
> > > 
> > > ...that wait_for_completion never returns.
> 
> [...]
> 
> Thanks for narrowing it down to wait_for_completion() call,
> it was an useful hint.

Thanks for a patch, I'll test it soon. Here are two really trivial
patches... maybe too trivial?

---

Small whitespace fixes for drivers/ide.

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 380fa0c..df70d36 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -617,7 +617,7 @@ static inline u8 probe_for_drive (ide_dr
 	return drive->present;
 }
 
-static void hwif_release_dev (struct device *dev)
+static void hwif_release_dev(struct device *dev)
 {
 	ide_hwif_t *hwif = container_of(dev, ide_hwif_t, gendev);
 
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index c758dcb..846bcfb 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1,6 +1,6 @@
 /*
  *  Copyright (C) 1994-1998	    Linus Torvalds & authors (see below)
- *  Copyrifht (C) 2003-2005, 2007   Bartlomiej Zolnierkiewicz
+ *  Copyright (C) 2003-2005, 2007   Bartlomiej Zolnierkiewicz
  */
 
 /*


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html