Re: [RFC patch 00/12] Tracepoints v2

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Eduard - Gabriel Munteanu (eduard.munteanu@linux360.ro) wrote:
> On Fri, 04 Jul 2008 19:52:07 -0400
> Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> 
> > Hi,
> > 
> > Here is the second release of kernel tracepoints, including the
> > architecture independent instrumentation taken from LTTng. I submit
> > this for another round of comments.
> 
> Hi,
> 
> Not using format specifiers sounds pretty nice. Are there any other
> advantages over markers? What about self-modifying code, does it employ
> this technique to eliminate conditional branching (markers did this on
> some arches, IIRC)?
> 

The main advantage is to remove the format strings. It also permits to
declare the tracepoints in a header file instead of only spreading them
all over the kernel code. It aims at providing an internal kernel
interface to kernel tracers, compared to markers which are eventually
meant to export the trace information, along with the format specifiers,
to userspace. The version I sent here does not use immediate values
(self-modifying code), but the one I have in my patchset does.

> I'm considering using this for kmemtrace, so please keep me Cc-ed if
> possible.
> 

Sure, I will,

Mathieu

> 
> 	Cheers,
> 	Eduard
> 
> P.S.: BTW, the To header is either broken or I screwed it (I'm reading
> this via Gmane's NNTP):
> "Steven Rostedt <ros"

Ok, will fix in the next post. Thanks.

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68