From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lenb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 5/5] x86 PCI: use dev_printk when possible
Date: Mon, 7 Jul 2008 16:10:35 -0600 [thread overview]
Message-ID: <200807071610.36528.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200807011857.42384.jbarnes@virtuousgeek.org>
On Tuesday 01 July 2008 07:57:41 pm Jesse Barnes wrote:
> On Monday, June 30, 2008 4:57 pm Andrew Morton wrote:
> > On Fri, 13 Jun 2008 10:52:14 -0600
> >
> > Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > I converted DBG() to dev_dbg(). This DBG() is from arch/x86/pci/pci.h
> > > and requires source-code modification to enable, so dev_dbg() seems
> > > roughly equivalent.
> > >
> > > The printks in arch/x86/pci/irq.c were a little hairy, with lines
> > > printed in several pieces. I straightened it out a little, but
> > > another set of eyes would be good.
> > >
> > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> > >
> > > ---
> > > arch/x86/pci/fixup.c | 3 +
> > > arch/x86/pci/i386.c | 26 ++++++--------
> > > arch/x86/pci/irq.c | 91
> > > ++++++++++++++++++++++----------------------------- arch/x86/pci/numa.c
> > > | 5 +-
> >
> > Got a bunch of rejects in arch/x86/pci/irq.c due to pending whitespace
> > fixes. I fixed a couple of them but then I got bored, so the
> > conversion in there is only partial.
> >
> > Please prefer to raise patches against linux-next if poss, especially
> > during late -rc's.
>
> Yeah, the x86 tree(s) move too fast for me to keep up with. The change seems
> worthwhile though, maybe Ingo or one of the x86 team could just search &
> replace?
I'll fix it up.
Bjorn
next prev parent reply other threads:[~2008-07-07 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 16:52 [patch 0/5] dev_printk() conversions Bjorn Helgaas
2008-06-13 16:52 ` [patch 1/5] ACPI: use dev_printk when possible Bjorn Helgaas
2008-06-26 3:42 ` Len Brown
2008-06-13 16:52 ` [patch 2/5] PCI: " Bjorn Helgaas
2008-06-13 16:52 ` [patch 3/5] PCIE: aer: " Bjorn Helgaas
2008-06-13 16:52 ` [patch 4/5] PCIE: port driver: " Bjorn Helgaas
2008-06-13 16:52 ` [patch 5/5] x86 PCI: " Bjorn Helgaas
2008-06-26 3:48 ` Len Brown
2008-06-30 23:57 ` Andrew Morton
2008-07-02 1:57 ` Jesse Barnes
2008-07-07 22:10 ` Bjorn Helgaas [this message]
2008-06-25 23:07 ` [patch 0/5] dev_printk() conversions Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807071610.36528.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®