From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>, benh@kernel.crashing.org
Cc: Zan Lynx <zlynx@acm.org>, Ryan Hope <rmh3093@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Lockless/Get_User_Pages_Fast causes Xorg 1.4.99.* to lock
Date: Mon, 7 Jul 2008 17:55:39 +1000 [thread overview]
Message-ID: <200807071755.40477.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0807042112130.16912@blonde.site>
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
On Saturday 05 July 2008 06:29, Hugh Dickins wrote:
> Fix to 2.6.26-rc8-mm1 x86-implement-pte_special.patch
> Perhaps something similar needed for powerpc? Nick will know.
Here is the required fix for powerpc-implement-pte_special.patch
[-- Attachment #2: powerpc-implement-pte_special-fix.patch --]
[-- Type: text/x-diff, Size: 838 bytes --]
Spotted by Hugh:
Stop mprotect's pte_modify from wiping out the powerpc pte_special bit, which
caused oops thereafter when vm_normal_page thought X's abnormal was normal.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/include/asm-powerpc/pgtable-4k.h
===================================================================
--- linux-2.6.orig/include/asm-powerpc/pgtable-4k.h
+++ linux-2.6/include/asm-powerpc/pgtable-4k.h
@@ -60,7 +60,7 @@
/* It should be preserving the high 48 bits and then specifically */
/* preserving _PAGE_SECONDARY | _PAGE_GROUP_IX */
#define _PAGE_CHG_MASK (PAGE_MASK | _PAGE_ACCESSED | _PAGE_DIRTY | \
- _PAGE_HPTEFLAGS)
+ _PAGE_SPECIAL | _PAGE_HPTEFLAGS)
/* Bits to mask out from a PMD to get to the PTE page */
#define PMD_MASKED_BITS 0
next prev parent reply other threads:[~2008-07-07 7:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 6:26 Ryan Hope
2008-07-04 16:29 ` Zan Lynx
2008-07-04 20:29 ` Hugh Dickins
2008-07-05 5:26 ` Ryan Hope
2008-07-06 21:03 ` Zan Lynx
2008-07-07 7:01 ` Nick Piggin
2008-07-07 7:55 ` Nick Piggin [this message]
2008-07-07 8:06 ` Nick Piggin
2008-07-07 10:39 ` Hugh Dickins
2008-07-07 11:08 ` Martin Schwidefsky
2008-07-07 11:39 ` Nick Piggin
2008-07-07 12:02 ` Hugh Dickins
2008-07-07 15:43 ` Carsten Otte
2008-07-07 16:16 ` Ryan Hope
2008-07-07 16:38 ` Carsten Otte
2008-07-07 17:01 ` Ryan Hope
2008-07-07 17:48 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807071755.40477.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmh3093@gmail.com \
--cc=zlynx@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®