From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757810AbYGHMmk (ORCPT ); Tue, 8 Jul 2008 08:42:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756597AbYGHMmR (ORCPT ); Tue, 8 Jul 2008 08:42:17 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:41758 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754854AbYGHMmO (ORCPT ); Tue, 8 Jul 2008 08:42:14 -0400 Date: Tue, 8 Jul 2008 08:42:08 -0400 From: Christoph Hellwig To: Johannes Berg Cc: Andrew Morton , linux-wireless , Linux Kernel list , Herbert Xu , Tomas Winkler , rusty Subject: Re: [PATCH] CONFIG_KMOD needs to be default y Message-ID: <20080708124208.GA6704@infradead.org> References: <1215517771.9610.28.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1215517771.9610.28.camel@johannes.berg> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2008 at 01:49:31PM +0200, Johannes Berg wrote: > Far too many people configure their kernel without CONFIG_KMOD > and then complain that wireless breaks, thanks to Herbert Xu for > pointing me to this. > > This patch makes CONFIG_KMOD default to "y" and adds a warning > that people should not turn it off. What about just killing the config option entirely? It' basically guarding a ~50 lines function + a sysctl variable. I think having modules but not CONFIG_KMOD is entirely unreasonable.