mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Robert Richter <robert.richter@amd.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci
Date: Fri, 11 Jul 2008 12:23:10 +0200	[thread overview]
Message-ID: <20080711102310.GA17033@elte.hu> (raw)
In-Reply-To: <20080711102205.GA22725@uranus.ravnborg.org>


* Sam Ravnborg <sam@ravnborg.org> wrote:

> > > > 
> > > > So if I am not mistaken you can kill pci-y entirely:
> > 
> > Yes, but...
> > 
> > > > 
> > > > obj-y                           := fixup.o
> > 
> > ... this is with a plus:
> > 
> > obj-y                           += fixup.o
> 
> obj-y is empty when you enter the Makefile.
> So if you start out with ':=' or '+=' is no difference.

i guess it's safer to use +=, because it's ordering invariant.

We should use := only if we absolutely want to override the current 
rules.

	Ingo

  reply	other threads:[~2008-07-11 10:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 16:58 Robert Richter
2008-07-10 16:58 ` [PATCH 1/5] x86/pci: Fix build error for X86_VISWS Robert Richter
2008-07-10 16:58 ` [PATCH 2/5] x86/pci: Makefile merge: Changing 32bit ordering Robert Richter
2008-07-10 16:58 ` [PATCH 3/5] x86/pci merge: Fixing numaq initialization Robert Richter
2008-07-10 17:51   ` Yinghai Lu
2008-07-10 16:58 ` [PATCH 4/5] x86/pci: Fix warnings in subsys_initcall functions Robert Richter
2008-07-10 16:58 ` [PATCH 5/5] x86: build fix for "x86: fix C1E && nx6325 stability problem" Robert Richter
2008-07-10 17:17 ` [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci Ingo Molnar
2008-07-10 18:12   ` Ingo Molnar
2008-07-10 19:52     ` Sam Ravnborg
2008-07-10 19:54       ` Ingo Molnar
2008-07-11  8:20         ` Robert Richter
2008-07-11 10:22           ` Sam Ravnborg
2008-07-11 10:23             ` Ingo Molnar [this message]
2008-07-11 10:28               ` Sam Ravnborg
2008-07-11  8:43     ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711102310.GA17033@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@amd.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®