From: Jean Delvare <khali@linux-fr.org>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] dev_printk doesn't modify dev
Date: Fri, 11 Jul 2008 11:12:16 +0200 [thread overview]
Message-ID: <20080711111216.638d0ad3@hyperion.delvare> (raw)
Add const markings to dev_name and dev_driver_string to make it clear
that dev_printk doesn't modify dev. This is a prerequisite to adding
more const markings to other functions make it clearer, which
functions can modify dev and which can't.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/base/core.c | 2 +-
include/linux/device.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.26-rc9.orig/include/linux/device.h 2008-06-05 12:25:13.000000000 +0200
+++ linux-2.6.26-rc9/include/linux/device.h 2008-07-11 10:47:03.000000000 +0200
@@ -379,7 +379,7 @@ struct device {
/* Get the wakeup routines, which depend on struct device */
#include <linux/pm_wakeup.h>
-static inline const char *dev_name(struct device *dev)
+static inline const char *dev_name(const struct device *dev)
{
/* will be changed into kobject_name(&dev->kobj) in the near future */
return dev->bus_id;
@@ -495,7 +495,7 @@ extern void device_shutdown(void);
extern void sysdev_shutdown(void);
/* debugging and troubleshooting/diagnostic helpers. */
-extern const char *dev_driver_string(struct device *dev);
+extern const char *dev_driver_string(const struct device *dev);
#define dev_printk(level, dev, format, arg...) \
printk(level "%s %s: " format , dev_driver_string(dev) , \
dev_name(dev) , ## arg)
--- linux-2.6.26-rc9.orig/drivers/base/core.c 2008-06-13 16:08:57.000000000 +0200
+++ linux-2.6.26-rc9/drivers/base/core.c 2008-07-11 10:47:37.000000000 +0200
@@ -49,7 +49,7 @@ static inline int device_is_not_partitio
* it is attached to. If it is not attached to a bus either, an empty
* string will be returned.
*/
-const char *dev_driver_string(struct device *dev)
+const char *dev_driver_string(const struct device *dev)
{
return dev->driver ? dev->driver->name :
(dev->bus ? dev->bus->name :
--
Jean Delvare
reply other threads:[~2008-07-11 9:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711111216.638d0ad3@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®