From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
linux-serial@vger.kernel.org, Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] serial8250: Sanity check nr_uarts on all paths.
Date: Fri, 11 Jul 2008 21:05:16 +0100 [thread overview]
Message-ID: <20080711210516.02a04245@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <m1wsjsdxr1.fsf@frodo.ebiederm.org>
On Fri, 11 Jul 2008 12:30:42 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>
> I had 8250.nr_uarts=16 in the boot line of a test kernel and I had a
> weird mysterious crash in sysfs. After an taking in depth look I realized
> that CONFIG_SERIAL_8250_NR_UARTS was set to 4 and I was walking off
> the end of the serial8250_ports array.
>
> Ouch!!!
>
> Don't let this happen to someone else.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Alan Cox <alan@redhat.com>
Added to ttydev tree but please fire straight at Linus in case he fancies
it for 2.6.26
next prev parent reply other threads:[~2008-07-11 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 19:30 Eric W. Biederman
2008-07-11 20:05 ` Alan Cox [this message]
2008-07-11 20:37 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711210516.02a04245@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®