From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Tom Zanussi <tzanussi@gmail.com>,
Jens Axboe <jens.axboe@oracle.com>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [mmotm] smp.c: fix build error
Date: Sat, 12 Jul 2008 20:11:02 +0900 [thread overview]
Message-ID: <20080712200835.F6AC.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
Against: mmotm
Patch name: full-conversion-to-early_initcall-interface-remove-old-interface-fix-fix.patch
Applies after: full-conversion-to-early_initcall-interface-remove-old-interface-fix.patch
--------------------------------
Now, init_call_single_data() is static function.
then redundant declaration cause build error as below.
kernel/smp.c:36: error: static declaration of ‘init_call_single_data’ follows non-static declaration
include/linux/smp.h:77: error: previous declaration of ‘init_call_single_data’ was here
kernel/smp.c:47: warning: initialization from incompatible pointer type
make[1]: *** [kernel/smp.o] error 1
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
---
include/linux/smp.h | 5 -----
1 file changed, 5 deletions(-)
Index: b/include/linux/smp.h
===================================================================
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -74,15 +74,10 @@ void __smp_call_function_single(int cpui
#ifdef CONFIG_USE_GENERIC_SMP_HELPERS
void generic_smp_call_function_single_interrupt(void);
void generic_smp_call_function_interrupt(void);
-void init_call_single_data(void);
void ipi_call_lock(void);
void ipi_call_unlock(void);
void ipi_call_lock_irq(void);
void ipi_call_unlock_irq(void);
-#else
-static inline void init_call_single_data(void)
-{
-}
#endif
/*
next reply other threads:[~2008-07-12 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 11:11 KOSAKI Motohiro [this message]
2008-07-12 16:45 ` Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080712200835.F6AC.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®