mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Jakub W. Jozwicki" <jozwicki@aster.pl>
Cc: linux-kernel@vger.kernel.org, jgarzik@redhat.com
Subject: Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic
Date: Sun, 13 Jul 2008 11:25:43 +0100	[thread overview]
Message-ID: <20080713112543.2dc9d6f7@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200807130127.36706.jozwicki@aster.pl>

On Sun, 13 Jul 2008 01:27:36 +0200
"Jakub W. Jozwicki" <jozwicki@aster.pl> wrote:

> Change locking surrounding kmap_atomic from local_irqsave to 
> local_irqsave_nort. This fixes issues with PREEMPT_RT.
>  
> Signed-off-by:  Jakub Jozwicki <jozwicki@aster.pl>

The right way to fix this is to use a bounce buffer. I sent Jeff patches
to do that a couple of times. I'm not sure what has happened to them
since ? So NAK this, we should apply the patch to actually fix the bug
instead.

Jeff ?

Alan

  parent reply	other threads:[~2008-07-13 10:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 23:27 Jakub W. Jozwicki
2008-07-13  8:26 ` Andrew Morton
2008-07-13 13:17   ` Jakub W. Jozwicki
2008-07-13 17:46     ` Jeremy Fitzhardinge
2008-07-13 18:53       ` Jakub W. Jozwicki
2008-07-13 21:32         ` Jeremy Fitzhardinge
2008-07-13 10:25 ` Alan Cox [this message]
2008-07-13 13:30   ` Jakub W. Jozwicki
2008-07-13 14:15     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080713112543.2dc9d6f7@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@redhat.com \
    --cc=jozwicki@aster.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®