mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Rus <harbour@sfinx.od.ua>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [mmotm] pm: fix build error
Date: Mon, 14 Jul 2008 09:34:14 +0200	[thread overview]
Message-ID: <20080714073414.GB1796@elf.ucw.cz> (raw)
In-Reply-To: <20080714162102.F6D1.KOSAKI.MOTOHIRO@jp.fujitsu.com>

Hi!

> My IA64 machine can't build on today's mmotm(Jul 13).
> So, below patch is necessary, I think.
> 
> ----------------------------------------------------
> Against: mmotm, Jul 13
> Applies after: pm-schedule-sysrq-poweroff-on-boot-cpu.patch
> 
> Now, handle_poweroff() use cpu_online_map variable.
> So cpumask.h sould be included.
> Otherwise it cause following build error on ia64 (I guess also sevaral othor platfom).
> 
> 	kernel/power/poweroff.c: In function 'handle_poweroff':
> 	kernel/power/poweroff.c:29: error: implicit declaration of function 'first_cpu'
> 	kernel/power/poweroff.c:29: error: 'cpu_online_map' undeclared (first use in this function)
> 	kernel/power/poweroff.c:29: error: (Each undeclared identifier is reported only once
> 	kernel/power/poweroff.c:29: error: for each function it appears in.)
> 	make[2]: *** [kernel/power/poweroff.o] Error 1
> 	make[1]: *** [kernel/power] Error 2
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Zhang Rui <rui.zhang@intel.com>
> CC: Rus <harbour@sfinx.od.ua>
> CC: Rafael J. Wysocki <rjw@sisk.pl>
> CC: Pavel Machek <pavel@ucw.cz>

ACK.

> ---
>  kernel/power/poweroff.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: b/kernel/power/poweroff.c
> ===================================================================
> --- a/kernel/power/poweroff.c
> +++ b/kernel/power/poweroff.c
> @@ -10,6 +10,7 @@
>  #include <linux/pm.h>
>  #include <linux/workqueue.h>
>  #include <linux/reboot.h>
> +#include <linux/cpumask.h>
>  
>  /*
>   * When the user hits Sys-Rq o to power down the machine this is the
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2008-07-14  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14  7:23 KOSAKI Motohiro
2008-07-14  7:34 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080714073414.GB1796@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=harbour@sfinx.od.ua \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®