mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: John Keller <jpk@sgi.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: x86: PCI multi domain/segment config access
Date: Mon, 14 Jul 2008 14:28:10 -0700	[thread overview]
Message-ID: <200807141428.11022.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080711212117.GW14894@parisc-linux.org>

On Friday, July 11, 2008 2:21 pm Matthew Wilcox wrote:
> On Fri, Jul 11, 2008 at 04:13:47PM -0500, John Keller wrote:
> > On x86 PCI Config space access to domains/segments > 0 appears to be
> > broken. The noted patch related to PCI ext config space has all config
> > accesses to offsets < 256 using conf1 if available, which is most likely
> > the case.
> >
> > This would force usage of conf1 for non-extended config access (< 256) on
> > PCI domains > 0.
> >
> > Am I missing something, or how would a conf1 access reference a domain
> > other than zero?
>
> You're correct.  Sorry about that, I wasn't thinking about domains at
> the time I wrote the patch.  Try this:
>
> [X86] Fix PCI config space for domains > 0
>
> John Keller reports that PCI config space access is broken on machines
> with more than one domain.  conf1 accesses only work for domain 0.
>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

Oops, yeah, good catch.  Thanks for fixing this up, Matthew.  Just applied it 
to my linux-next branch.

Thanks,
Jesse

      parent reply	other threads:[~2008-07-14 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11 21:13 John Keller
2008-07-11 21:21 ` Matthew Wilcox
2008-07-11 21:44   ` John Keller
2008-07-14 21:28   ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807141428.11022.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=jpk@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome