From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] workqueue: proper error unwinding in cpu hotplug error path
Date: Tue, 15 Jul 2008 17:12:10 +0900 [thread overview]
Message-ID: <20080715081210.GC22068@localhost.localdomain> (raw)
Add proper error unwinding in error path in CPU_UP_PREPARE notifier.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
kernel/workqueue.c | 9 +++++++++
1 file changed, 9 insertions(+)
Index: 2.6-mmotm/kernel/workqueue.c
===================================================================
--- 2.6-mmotm.orig/kernel/workqueue.c
+++ 2.6-mmotm/kernel/workqueue.c
@@ -928,6 +928,15 @@ static int __devinit workqueue_cpu_callb
break;
printk(KERN_ERR "workqueue [%s] for %i failed\n",
wq->name, cpu);
+
+ list_for_each_entry_continue_reverse(wq, &workqueues,
+ list) {
+ cwq = per_cpu_ptr(wq->cpu_wq, cpu);
+ start_workqueue_thread(cwq, -1);
+ cleanup_workqueue_thread(cwq);
+ }
+ cpu_clear(cpu, cpu_populated_map);
+
return NOTIFY_BAD;
case CPU_ONLINE:
reply other threads:[~2008-07-15 8:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080715081210.GC22068@localhost.localdomain \
--to=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®