Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

[Stephen Rothwell <sfr@canb.auug.org.au>]

[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]

Hi Anton,

On Mon, 14 Jul 2008 20:41:14 +0400 Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> +static int __devinit of_gpio_leds_probe(struct of_device *ofdev,
> +					const struct of_device_id *match)
> +{
> +	int ret;
> +	struct of_gpio_led *led;
> +	struct device_node *np = ofdev->node;
> +
> +	led = kzalloc(sizeof(*led), GFP_KERNEL);
> +	if (!led)
> +		return -ENOMEM;
> +
> +	led->np = np;

You need to take a reference if you are keeping a pointer to a
device_node, so:
	led->np = of_node_get(np);

> +	led->cdev.name = of_get_property(np, "label", NULL);
> +	if (!led->cdev.name)
> +		led->cdev.name = ofdev->dev.bus_id;

Please use dev_name() in new code:
		led->cdev.name = dev_name(&ofdev->dev);

> +	led->cdev.brightness_set = gpio_led_set;
> +
> +	ret = gpio_request(led->gpio, ofdev->dev.bus_id);

dev_name() again.

> +err_get_gpio:

	of_node_put(led->np);

> +	kfree(led);
> +	return ret;
> +}
> +
> +static int __devexit of_gpio_leds_remove(struct of_device *ofdev)
> +{
> +	struct of_gpio_led *led = dev_get_drvdata(&ofdev->dev);
> +
> +	led_classdev_unregister(&led->cdev);
> +	cancel_work_sync(&led->work);
> +	gpio_free(led->gpio);
> +	of_node_put(led->np);

This was going to be unbalanced, but is now correct.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]