From: Adrian Bunk <bunk@kernel.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] chsc headers userspace cleanup
Date: Wed, 16 Jul 2008 00:02:30 +0300 [thread overview]
Message-ID: <20080715210230.GK24533@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080715191748.1f3905ad@gondolin.boeblingen.de.ibm.com>
On Tue, Jul 15, 2008 at 07:17:48PM +0200, Cornelia Huck wrote:
> On Tue, 15 Jul 2008 15:58:18 +0300,
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > Kernel headers shouldn't expose functions to userspace.
>
> Could you please elaborate? Especially as I see e.g.
> include/linux/virtio_ring.h exporting functions outside #ifdef
> __KERNEL__ as well...
Our headers are in a bad shape...
The userspace headers should contain everything that is part of the ABI
between the kernel and userspace.
Nothing more.
The kernel is heavily changing with each release while the userspace ABI
is cast in stone, and leaking more stuff to userspace than required only
increases the chances of some userspace programmer using it and some
kernel programmer then changing it.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-07-15 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 12:58 Adrian Bunk
2008-07-15 17:17 ` Cornelia Huck
2008-07-15 21:02 ` Adrian Bunk [this message]
2008-07-16 8:15 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080715210230.GK24533@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=cornelia.huck@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®