From: Oliver Neukum <oliver@neukum.org>
To: Julia Lawall <julia@diku.dk>
Cc: zaitcev@redhat.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/usb/class/usblp.c: adjust error handling code
Date: Wed, 16 Jul 2008 17:44:58 +0200 [thread overview]
Message-ID: <200807161744.59137.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0807161717220.28783@ask.diku.dk>
Am Mittwoch 16 Juli 2008 17:17:42 schrieb Julia Lawall:
> From: Julia Lawall <julia@diku.dk>
>
> In this code, it is possible to tell statically whether usblp will be NULL
> in the error handling code.
>
> Another option would have been to put a label directly on the return.
That would be better. It means less chance to overlook an error case
if locking needs to be added in the future.
Regards
Oliver
next prev parent reply other threads:[~2008-07-16 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 15:17 Julia Lawall
2008-07-16 15:44 ` Oliver Neukum [this message]
2008-07-16 16:00 ` [PATCH retry] " Julia Lawall
2008-07-16 16:44 ` [PATCH] " Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807161744.59137.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome