From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, davej@redhat.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
Date: Wed, 16 Jul 2008 16:47:23 -0500 [thread overview]
Message-ID: <20080716214722.GA6251@ld0162-tx32.am.freescale.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0807160838520.14127@blarg.am.freescale.net>
On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> If we don't enable FS_ENET we get build issues:
>
> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
> +#ifdef CONFIG_FS_ENET_MDIO_FCC
> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
> {
> if (level)
> @@ -164,6 +165,7 @@ static struct of_platform_driver ep8248e_mdio_driver = {
> .probe = ep8248e_mdio_probe,
> .remove = ep8248e_mdio_remove,
> };
> +#endif
This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
-Scott
next prev parent reply other threads:[~2008-07-16 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 13:39 Kumar Gala
2008-07-16 21:47 ` Scott Wood [this message]
2008-07-16 21:57 ` Dave Jones
2008-07-16 22:10 ` Kumar Gala
2008-07-16 22:19 ` Dave Jones
2008-07-16 22:55 ` Kumar Gala
2008-07-21 16:14 ` Scott Wood
2008-07-16 22:23 ` Kumar Gala
2008-07-21 16:13 ` Scott Wood
2008-07-16 22:01 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716214722.GA6251@ld0162-tx32.am.freescale.net \
--to=scottwood@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®