mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: [PATCH 04/23] tracehook: exit
Date: Thu, 17 Jul 2008 00:28:40 -0700 (PDT)	[thread overview]
Message-ID: <20080717072840.C60F91541A5@magilla.localdomain> (raw)
In-Reply-To: Roland McGrath's message of  Thursday, 17 July 2008 00:25:41 -0700 <20080717072541.F390E15411D@magilla.localdomain>

This moves the PTRACE_EVENT_EXIT tracing into a tracehook.h inline,
tracehook_report_exec().  The change has no effect, just clean-up.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 include/linux/tracehook.h |   15 +++++++++++++++
 kernel/exit.c             |    6 ++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
index 6276353..967ab47 100644
--- a/include/linux/tracehook.h
+++ b/include/linux/tracehook.h
@@ -95,4 +95,19 @@ static inline void tracehook_report_exec(struct linux_binfmt *fmt,
 		send_sig(SIGTRAP, current, 0);
 }
 
+/**
+ * tracehook_report_exit - task has begun to exit
+ * @exit_code:		pointer to value destined for @current->exit_code
+ *
+ * @exit_code points to the value passed to do_exit(), which tracing
+ * might change here.  This is almost the first thing in do_exit(),
+ * before freeing any resources or setting the %PF_EXITING flag.
+ *
+ * Called with no locks held.
+ */
+static inline void tracehook_report_exit(long *exit_code)
+{
+	ptrace_event(PT_TRACE_EXIT, PTRACE_EVENT_EXIT, *exit_code);
+}
+
 #endif	/* <linux/tracehook.h> */
diff --git a/kernel/exit.c b/kernel/exit.c
index 93d2711..bd243c3 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -46,6 +46,7 @@
 #include <linux/resource.h>
 #include <linux/blkdev.h>
 #include <linux/task_io_accounting_ops.h>
+#include <linux/tracehook.h>
 
 #include <asm/uaccess.h>
 #include <asm/unistd.h>
@@ -1005,10 +1006,7 @@ NORET_TYPE void do_exit(long code)
 	if (unlikely(!tsk->pid))
 		panic("Attempted to kill the idle task!");
 
-	if (unlikely(current->ptrace & PT_TRACE_EXIT)) {
-		current->ptrace_message = code;
-		ptrace_notify((PTRACE_EVENT_EXIT << 8) | SIGTRAP);
-	}
+	tracehook_report_exit(&code);
 
 	/*
 	 * We're taking recursive faults here in do_exit. Safest is to just

  parent reply	other threads:[~2008-07-17  7:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17  7:25 [PATCH 00/23] tracehook Roland McGrath
2008-07-17  7:27 ` [PATCH 01/23] tracehook: add linux/tracehook.h Roland McGrath
2008-07-17  8:48   ` Alexey Dobriyan
2008-07-17 11:06     ` Petr Tesarik
2008-07-17 21:50       ` Alexey Dobriyan
2008-07-17 13:34     ` Christoph Hellwig
2008-07-18 11:57       ` Petr Tesarik
2008-07-17  7:28 ` [PATCH 02/23] tracehook: exec Roland McGrath
2008-07-21  8:49   ` Christoph Hellwig
2008-07-17  7:28 ` [PATCH 03/23] tracehook: unexport ptrace_notify Roland McGrath
2008-07-17  7:28 ` Roland McGrath [this message]
2008-07-17  7:29 ` [PATCH 05/23] tracehook: clone Roland McGrath
2008-07-17  7:29 ` [PATCH 06/23] tracehook: vfork-done Roland McGrath
2008-07-17  7:29 ` [PATCH 07/23] tracehook: release_task Roland McGrath
2008-07-17  7:29 ` [PATCH 08/23] tracehook: tracehook_tracer_task Roland McGrath
2008-07-17  7:29 ` [PATCH 09/23] tracehook: tracehook_expect_breakpoints Roland McGrath
2008-07-17  7:30 ` [PATCH 10/23] tracehook: tracehook_signal_handler Roland McGrath
2008-07-17  7:30 ` [PATCH 11/23] tracehook: tracehook_consider_ignored_signal Roland McGrath
2008-07-17  7:30 ` [PATCH 12/23] tracehook: tracehook_consider_fatal_signal Roland McGrath
2008-07-17  7:30 ` [PATCH 13/23] tracehook: syscall Roland McGrath
2008-07-17  7:30 ` [PATCH 14/23] tracehook: get_signal_to_deliver Roland McGrath
2008-07-17  7:30 ` [PATCH 15/23] tracehook: job control Roland McGrath
2008-07-17  7:30 ` [PATCH 16/23] tracehook: death Roland McGrath
2008-07-17  7:30 ` [PATCH 17/23] tracehook: force signal_pending() Roland McGrath
2008-07-17  7:31 ` [PATCH 18/23] tracehook: TIF_NOTIFY_RESUME Roland McGrath
2008-07-17  7:31 ` [PATCH 19/23] tracehook: asm/syscall.h Roland McGrath
2008-07-17  7:31 ` [PATCH 20/23] tracehook: CONFIG_HAVE_ARCH_TRACEHOOK Roland McGrath
2008-07-17  7:31 ` [PATCH 21/23] tracehook: wait_task_inactive Roland McGrath
2008-07-17  7:31 ` [PATCH 22/23] task_current_syscall Roland McGrath
2008-07-17  7:31 ` [PATCH 23/23] /proc/PID/syscall Roland McGrath
2008-07-17 22:56   ` Alexey Dobriyan
2008-07-21  8:19     ` Roland McGrath
2008-07-17  7:39 ` [PATCH 00/23] tracehook Andrew Morton
2008-07-17  8:11   ` Roland McGrath
2008-07-17  8:30     ` Andrew Morton
2008-07-17  8:37       ` Roland McGrath
2008-07-17  8:51 ` Andrew Morton
2008-07-18  8:07   ` Ingo Molnar
2008-07-21  9:59   ` Roland McGrath
2008-07-18  9:20 ` David Miller
2008-07-18 11:24   ` Andi Kleen
2008-07-18 11:32     ` David Miller
2008-07-21 10:54   ` Roland McGrath
2008-07-21 15:18     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080717072840.C60F91541A5@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®