mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Thu, 17 Jul 2008 15:50:32 -0300	[thread overview]
Message-ID: <20080717185032.GD18457@khazad-dum.debian.net> (raw)
In-Reply-To: <487F7724.5080905@tuffmail.co.uk>

On Thu, 17 Jul 2008, Alan Jenkins wrote:
> Actually Alexey has another patch in bugzilla (#10919) which resolves
> this issue in a better way.  It avoids polling altogether, which is good
> because it means you get events immediately.  My laptop has backlight
> adjustment hotkeys with hardware autorepeat, so it looks really jerky
> with polling.

We need to get ALL pending events from the EC, whether in polling mode or in
interrupt mode (and we must make sure that we ARE going to queue any new
interrupt before we stop checking for an empty pending event queue,
otherwise there is a small window where a new event might get queued, and we
are still masking the GPE and don't notice it).  As long as the fix does
that, it is all I care :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2008-07-17 18:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 22:25 Alan Jenkins
2008-07-17 11:49 ` Alexey Starikovskiy
2008-07-17 12:13   ` Henrique de Moraes Holschuh
2008-07-17 12:30     ` Alexey Starikovskiy
2008-07-17 16:26       ` Henrique de Moraes Holschuh
2008-07-17 16:45         ` Alan Jenkins
2008-07-17 18:50           ` Henrique de Moraes Holschuh [this message]
2008-07-17 19:07             ` Alan Jenkins
2008-07-19 11:37               ` [PATCH 0/3] acpi: GPE fixes Alan Jenkins
2008-07-19 14:07                 ` Vegard Nossum
     [not found]               ` <4881CE72.1090401@tuffmail.co.uk>
2008-07-19 11:38                 ` [PATCH 1/3] acpi: Rip out EC_FLAGS_QUERY_PENDING (prevent race condition) Alan Jenkins
2008-07-19 16:59                   ` Alexey Starikovskiy
2008-07-19 20:41                     ` Alan Jenkins
2008-07-19 21:12                       ` Alexey Starikovskiy
2008-07-20 14:55                         ` Alan Jenkins
2008-07-19 11:39                 ` [PATCH 2/3] acpi: Avoid dropping rapid GPEs on Asus EeePC and others Alan Jenkins
2008-07-19 11:39                 ` [PATCH 3/3] acpi: remove GPE polling Alan Jenkins
2008-07-17 14:35 ` [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Alexey Starikovskiy
2008-07-17 16:02   ` Alan Jenkins
2008-07-17 16:45     ` Alexey Starikovskiy
2008-07-17 18:55       ` Alan Jenkins
2008-07-17 18:59         ` Alexey Starikovskiy
2008-08-12 23:28           ` Andrew Morton
2008-08-13 10:21             ` Alan Jenkins
2008-08-13 10:46               ` Andrew Morton
2008-08-13 11:45                 ` Alan Jenkins
2008-08-13 11:51                 ` Alan Jenkins
2008-08-13 13:36                   ` Maximilian Engelhardt
2008-08-13 14:39                     ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080717185032.GD18457@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=astarikovskiy@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome