mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Roland McGrath <roland@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/6] x86 tracehook patches
Date: Fri, 18 Jul 2008 10:26:58 +0200	[thread overview]
Message-ID: <20080718082658.GH6875@elte.hu> (raw)
In-Reply-To: <20080717074550.EE1E215411D@magilla.localdomain>


* Roland McGrath <roland@redhat.com> wrote:

> Hi!  Here is the x86 arch work that goes with the "tracehook" patch 
> series that I posted for the generic code.  I don't know how the 
> merging will go with that.  But when there is a tree containing all 
> that to base it on, you can merge these arch patches on top of that. 
> You can't take these without the generic tracehook series, some will 
> break the build until the generic file is there.
> 
> This series also requires as a baseline what you have in tip/x86/step.
> 
> The following changes since commit dc2cda6931dd54cd02b05da3a5bc969032e10992:
>   Roland McGrath (1):
>         x86 ptrace: user-sets-TF nits
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-utrace.git x86-tracehook
> 
> Roland McGrath (6):
>       x86: tracehook_signal_handler
>       x86: tracehook syscall
>       x86: tracehook: asm/syscall.h
>       x86 signals: use asm/syscall.h
>       x86: tracehook: TIF_NOTIFY_RESUME
>       x86: tracehook: CONFIG_HAVE_ARCH_TRACEHOOK

since Andrew picked up the generic bits into -mm i cannot put the 
generic+x86 bits into -tip.

Andrew, could you please pick up these x86 bits as well?

  Reviewed-by: Ingo Molnar <mingo@elte.hu>

Roland, a sidenote: your sha1's did not match that of tip/x86/step.

It's not a big issue in this case because Andrew takes patches but best 
practice is to not rebase commits you base future pull requests on. 
(rebasing is fine until something is WIP and put pushed/pulled - but 
it's lethal to transparency and mergability once patches have been 
published, so we try to avoid it as much as possible)

The way you could rebase existing commits back ontop of x86/step is to 
do this in your tracehook branch:

   git-rebase -i --onto tip/x86/step linus/master

(and if you've got fixes for x86/step then please send them as a pull 
request that just adds the fix in an append-only manner.)

	Ingo

      parent reply	other threads:[~2008-07-18  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17  7:45 Roland McGrath
2008-07-17  7:47 ` [PATCH 1/6] x86: tracehook_signal_handler Roland McGrath
2008-07-17  7:48 ` [PATCH 2/6] x86: tracehook syscall Roland McGrath
2008-07-17  7:48 ` [PATCH 3/6] x86: tracehook: asm/syscall.h Roland McGrath
2008-07-17  7:49 ` [PATCH 4/6] x86 signals: use asm/syscall.h Roland McGrath
2008-07-17  7:50 ` [PATCH 5/6] x86: tracehook: TIF_NOTIFY_RESUME Roland McGrath
2008-07-17  7:50 ` [PATCH 6/6] x86: tracehook: CONFIG_HAVE_ARCH_TRACEHOOK Roland McGrath
2008-07-18  8:26 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718082658.GH6875@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®