From: Ingo Molnar <mingo@elte.hu>
To: Roland McGrath <roland@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <aviro@redhat.com>, Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] x86_64 ia32 syscall audit fast-path
Date: Fri, 18 Jul 2008 13:36:15 +0200 [thread overview]
Message-ID: <20080718113615.GD6875@elte.hu> (raw)
In-Reply-To: <20080708000233.E8EF3154244@magilla.localdomain>
* Roland McGrath <roland@redhat.com> wrote:
> I don't know if there was some reason I did it that way rather than
> the other. I don't remember in which order I wrote and rewrote the
> patches. I'll cop to laziness if you like.
>
> It reminded me that I'd never tested the AMD (syscall/sysret) version
> of this path. That was clearly just plain lazy, and it was in fact
> broken. It's a good thing you called me names and made me feel bad
> about myself, so I cast about for more of my failings.
>
> This version of the patch changes what you didn't like, and it works
> right on both the AMD (syscall) and Intel (sysenter) paths. (Yes, I
> had already tested all the other paths. This is the only one that is
> not used on Intel hardware.)
do you have a delta patch against tip/x86/audit-speedup by any chance?
That is a topic branch of your previous drop, which got tested as well
to a certain degree. Would make it easier to see what changed, would
make the merge have a more nuanced history, etc.
or, alternatively, if you have a -git based branch that i could pull,
that would be nice as well. (i can compare old-x86/audit-speedup to
new-x86/audit-speedup.)
Ingo
next prev parent reply other threads:[~2008-07-18 11:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 6:56 [PATCH 1/4] x86_64: remove bogus optimization in sysret_signal Roland McGrath
2008-07-07 6:57 ` [PATCH 2/4] x86_64 syscall audit fast-path Roland McGrath
2008-07-07 6:57 ` [PATCH 3/4] x86_64 ia32 " Roland McGrath
2008-07-07 16:34 ` Linus Torvalds
2008-07-07 16:39 ` Linus Torvalds
2008-07-08 0:02 ` Roland McGrath
2008-07-08 0:37 ` Linus Torvalds
2008-07-18 11:36 ` Ingo Molnar [this message]
2008-07-21 23:54 ` Roland McGrath
2008-07-24 0:22 ` Linus Torvalds
2008-07-24 0:40 ` Linus Torvalds
2008-07-24 1:04 ` Roland McGrath
2008-07-07 6:58 ` [PATCH 4/4] i386 " Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718113615.GD6875@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=aviro@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome