mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: 4d3702b6 (post-v2.6.26): WARNING: at kernel/lockdep.c:2731 check_flags (ftrace)
Date: Fri, 18 Jul 2008 13:47:44 +0200	[thread overview]
Message-ID: <20080718114744.GF6875@elte.hu> (raw)
In-Reply-To: <19f34abd0807160232u635891fai2450f29e71c801b6@mail.gmail.com>


* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> On Wed, Jul 16, 2008 at 6:13 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > Things get weird between lockdep and ftrace because ftrace can be called
> > within lockdep internal code (via the mcount pointer) and lockdep can be
> > called with ftrace (via spin_locks).
> >
> > Can you try this patch out and see if it fixes your problem. I only
> > compiled tested it.
> >
> > Note: I'll be traveling for the next couple of weeks, so I will be on and
> > off with email.
> >
> > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> > ---
> >  kernel/trace/trace_sched_wakeup.c |   27 ++++++++++++++++-----------
> >  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> Works for me! :-)
> 
> There's no warning during self-tests. But then again, I didn't try 
> tracing anything else either.

applied to tip/tracing/urgent - thanks!

	Ingo

      parent reply	other threads:[~2008-07-18 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  1:55 Vegard Nossum
2008-07-16  2:05 ` Steven Rostedt
2008-07-16  4:13 ` Steven Rostedt
2008-07-16  9:32   ` Vegard Nossum
2008-07-16 11:36     ` Steven Rostedt
2008-07-18 11:47     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718114744.GF6875@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®