From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH ftrace.git] Immedate Values Optimized Jump Fix
Date: Sat, 19 Jul 2008 00:32:29 +0200 [thread overview]
Message-ID: <20080718223229.GH31073@elte.hu> (raw)
In-Reply-To: <20080718183124.GA31768@Krystal>
* Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:
> * Ingo Molnar (mingo@elte.hu) wrote:
> >
> > * Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:
> >
> > > Hi Ingo,
> > >
> > > This fix would apply to the ftrace tree which contains the jump-based
> > > immediate values. I don't know if this tree is still under active
> > > development, but I guess that it wouldn't hurt to fix it.
> > >
> > > Caused a kernel OOPS when loading the tracepoint probes once in a
> > > while on a 8-way x86_64.
> >
> > We've still got tip/tracing/immediates, with these commits from you:
> >
> > $ git-log-line linus.. arch/x86/kernel/immediate.c
> > ee563d6: immediate values: jump liveliness
> > e26875a: Immediate Values - Jump
> > 3fc8d03: Immediate Values - x86 Optimization NMI and MCE support
> >
> > ... but the topic is stalled right now, due to hpa having had
> > objections. Have those concerns been resolved? (Peter Cc:-ed)
> >
> > i'd have applied this fix, but it does not apply. The first chunk seems
> > already be present (in a different form), the second chunk looks much
> > different.
> >
> > Ingo
> >
>
> Hrm, I've edited directly the immediate values: jump liveliness patches,
> which explains why it does not apply. I'll try to unapply/reapply/fold
> the patches and see what it gives.
>
> Plus, I've noticed that the "Text Edit Lock" patches are not in the
> immediates branch, thus it fails to compile. Immediate values depends
> on the Text Edit Lock patches.
feel free to git-cherry-pick the commits together into a coherent unit
(preferrably all -git based), and we can give it a whirl in tip/master.
Ingo
prev parent reply other threads:[~2008-07-18 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 3:17 Mathieu Desnoyers
2008-07-18 16:15 ` Ingo Molnar
2008-07-18 18:31 ` Mathieu Desnoyers
2008-07-18 19:50 ` H. Peter Anvin
2008-07-18 21:12 ` Mathieu Desnoyers
2008-07-18 23:36 ` H. Peter Anvin
2008-07-18 23:38 ` H. Peter Anvin
2008-07-18 21:51 ` [git pull tip/tracing/immediates] Immediate values fixes/redux Mathieu Desnoyers
2008-07-19 5:59 ` Mathieu Desnoyers
2008-07-18 22:32 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718223229.GH31073@elte.hu \
--to=mingo@elte.hu \
--cc=compudj@krystal.dyndns.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome