mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
	Dave Hansen <haveblue@us.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	kernel-testers@vger.kernel.org, linux-next@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Bernhard Walle <bwalle@suse.de>, Ingo Molnar <mingo@elte.hu>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: linux-next: Tree for July 18: warning at kernel/lockdep.c:2068 trace_hardirqs_on_caller
Date: Sat, 19 Jul 2008 16:20:21 -0700	[thread overview]
Message-ID: <20080719232021.GA6476@suse.de> (raw)
In-Reply-To: <19f34abd0807191611y7cabf405iad307ba79591e04f@mail.gmail.com>

On Sun, Jul 20, 2008 at 01:11:36AM +0200, Vegard Nossum wrote:
> On Sun, Jul 20, 2008 at 12:58 AM, Greg KH <gregkh@suse.de> wrote:
> >> firmware_map_add_early() is using bootmem for the allocation. So yes,
> >> I guess it should possible to use kobjects here. That said, this code
> >> is in fact fairly recent:
> >>
> >> commit 69ac9cd629ca96e59f34eb4ccd12d00b2c8276a7
> >> Author: Bernhard Walle <bwalle@suse.de>
> >> Date:   Fri Jun 27 13:12:54 2008 +0200
> >>
> >>     sysfs: add /sys/firmware/memmap
> >>
> >> I'll add the Cc. I still have a feeling that the kobject patch should
> >> expect to run even when slab is not available.
> >
> > I never has been expected to do so in the past, so odds are, lots of
> > things might break :(
> 
> Yeah. Maybe you should withdraw your ack? :-D
> 
>     Signed-off-by: Bernhard Walle <bwalle@suse.de>
>     Acked-by: Greg KH <gregkh@suse.de>
>     Acked-by: Vivek Goyal <vgoyal@redhat.com>
>     Cc: kexec@lists.infradead.org
>     Cc: yhlu.kernel@gmail.com
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>

Heh, I didn't realize that this ran so early in the boot process, the
code logically looks correct :)

> I'm sorry for having been a bit rash earlier -- it's the combination
> of the patches that produce the failure; they both seem okay on their
> own. On the other hand, this is what -next is for, isn't it?

Yup.

> Maybe the firmware memmap code can simply run a little later in the
> boot sequence?

Possibly.  I wonder why this is only a problem on your machine and not
on anything that Ingo tested?

thanks,

greg k-h

  reply	other threads:[~2008-07-19 23:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18  9:53 linux-next: Tree for July 18 Stephen Rothwell
2008-07-19  7:28 ` linux-next: Tree for July 18: warning at kernel/lockdep.c:2068 trace_hardirqs_on_caller Mariusz Kozlowski
2008-07-19  9:55   ` Vegard Nossum
2008-07-19 12:56     ` Pekka Enberg
2008-07-19 12:59     ` Vegard Nossum
2008-07-19 13:22       ` Stephen Rothwell
2008-07-19 22:17       ` Greg KH
2008-07-19 22:27         ` Vegard Nossum
2008-07-19 22:41           ` Greg KH
2008-07-19 22:44           ` Vegard Nossum
2008-07-19 22:58             ` Greg KH
2008-07-19 23:11               ` Vegard Nossum
2008-07-19 23:20                 ` Greg KH [this message]
2008-07-20 12:51                   ` Bernhard Walle
2008-07-20  9:01                 ` Dave Hansen
2008-07-20  9:35                   ` Thomas Meyer
2008-07-20 13:03                   ` Bernhard Walle
2008-07-20 15:44                     ` Bernhard Walle
2008-07-21 13:17                   ` Vivek Goyal
2008-07-21 13:25                     ` Bernhard Walle
2008-07-21 13:39                       ` Vivek Goyal
2008-07-21 15:00                         ` Bernhard Walle
2008-07-22  6:15                           ` Yasunori Goto
2008-07-20 12:48             ` Bernhard Walle
2008-07-19  7:39 ` linux-next: Tree for July 18: nfs problems Mariusz Kozlowski
2008-07-19  9:35 ` linux-next: Tree for July 18: powerpc g3 hangs Mariusz Kozlowski
2008-07-19 15:31 ` linux-next: Tree for July 18 (very early crash on x86_32) Bartlomiej Zolnierkiewicz
2008-07-20  0:20 ` linux-next: Tree for July 18: sky2 WOL broken Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080719232021.GA6476@suse.de \
    --to=gregkh@suse.de \
    --cc=bwalle@suse.de \
    --cc=haveblue@us.ibm.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=m.kozlowski@tuxland.pl \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=sfr@canb.auug.org.au \
    --cc=vegard.nossum@gmail.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome